fix(tooltip): do not create arrow in SSR mode - 20.1.x #16281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RivaIvanova
added
❌ status: awaiting-test
RivaIvanova
requested review from
ChronosSF
and removed request for
gedinakova
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an SSR (Server-Side Rendering) issue by deferring tooltip arrow creation until after view initialization, ensuring it only happens in browser environments. The fix prevents errors when rendering tooltips on the server where DOM manipulation is not available.
- Moved arrow creation from constructor to
ngAfterViewInitwith browser environment check - Updated tooltip target to handle cases where arrow may not exist yet
- Updated test assertions to reflect new DOM structure (arrow element is now at index 0 instead of 1)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.ts | Deferred arrow creation to ngAfterViewInit with platform check to prevent SSR issues |
| projects/igniteui-angular/src/lib/directives/tooltip/tooltip-target.directive.ts | Added null checks for arrow element and moved arrow visibility logic to ngAfterViewInit |
| projects/igniteui-angular/src/lib/grids/grid/grid-validation.spec.ts | Updated test assertions to access error message from correct DOM child index |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
projects/igniteui-angular/src/lib/grids/grid/grid-validation.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid-validation.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid-validation.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid-validation.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid-validation.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid-validation.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid-validation.spec.ts
Outdated
Show resolved
Hide resolved
ChronosSF
approved these changes
Oct 20, 2025
14 tasks
IvanKitanov17
added
💥 status: in-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16273
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)